Skip to content

v14.15.5 proposal #37074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BethGriggs merged 10 commits into from
Feb 9, 2021
Merged

v14.15.5 proposal #37074

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2a1e4e9
stream: accept iterable as a valid first argument
Lxxyx Dec 11, 2020
c03cddb
test: http complete response after socket double end
mitsos1os Jan 10, 2021
25a3204
http: don't cork .end when not needed
mitsos1os Jan 15, 2021
9ff73fc
stream,zlib: do not use _stream_* anymore
mcollina Dec 24, 2020
408c7a6
deps: upgrade npm to 6.14.11
ruyadorno Feb 1, 2021
2f7944b
util: fix module prefixes during inspection
BridgeAR Nov 19, 2020
f206505
util: fix instanceof checks with null prototypes during inspection
BridgeAR Nov 19, 2020
20b1e6c
deps: V8: backport dfcf1e86fac0
targos Feb 7, 2021
017eed6
http: do not loop over prototype in Agent
targos Dec 6, 2020
9fff0d3
2021-02-09, Version 14.15.5 'Fermium' (LTS)
BethGriggs Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http: don't cork .end when not needed 
PR-URL: #36633
Backport-PR-URL: #36940
Fixes: #36620
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
  • Loading branch information
@mitsos1os @BethGriggs
mitsos1os authored and BethGriggs committed Jan 28, 2021
commit 25a3204fe29a8470f5a90a6bf424059757a09363
3 changes: 2 additions & 1 deletion lib/_http_outgoing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,8 @@ OutgoingMessage.prototype.end = function end(chunk, encoding, callback) {
encoding = null;
}

if (this.socket) {
// Not finished, socket exists and data will be written (chunk or header)
if (this.socket && !this.finished && (chunk || !this._header)) {
this.socket.cork();
}

Expand Down