Skip to content

http: fix ClientRequest unhandled errors #36970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 7 commits into from
Closed

http: fix ClientRequest unhandled errors #36970

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4fe8533
http: fix ClientRequest unhandled errors
ronag Jan 16, 2021
96e1c4f
fixup
ronag Jan 16, 2021
a077054
fixup
ronag Jan 16, 2021
44b35f3
fixup
ronag Feb 3, 2021
774665f
fixup
ronag Feb 3, 2021
d103ec1
Update test/parallel/test-http-client-abort3.js
ronag Feb 3, 2021
a5cb23a
Update test/parallel/test-http-client-abort3.js
ronag Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@ronag
ronag committed Jan 16, 2021
commit a077054985e661a1e552f9322ea0880522484809
8 changes: 3 additions & 5 deletions lib/_http_agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ const {
const { once } = require('internal/util');
const { validateNumber, validateOneOf } = require('internal/validators');

function nop() {}

const kOnKeylog = Symbol('onkeylog');
const kRequestOptions = Symbol('requestOptions');
const kRequestAsyncResource = Symbol('requestAsyncResource');
Expand Down Expand Up @@ -133,7 +131,7 @@ function Agent(options) {
// and could cause unhandled exception.

if (!socket.writable) {
socket.on('error', nop).destroy();
socket.destroy();
return;
}

Expand Down Expand Up @@ -161,7 +159,7 @@ function Agent(options) {
// the freeSockets pool, but only if we're allowed to do so.
const req = socket._httpMessage;
if (!req || !req.shouldKeepAlive || !this.keepAlive) {
socket.on('error', nop).destroy();
socket.destroy();
return;
}

Expand All @@ -175,7 +173,7 @@ function Agent(options) {
count > this.maxSockets ||
freeLen >= this.maxFreeSockets ||
!this.keepSocketAlive(socket)) {
socket.on('error', nop).destroy();
socket.destroy();
return;
}

Expand Down