Skip to content

[v14.x Backport] http: don't cork noop .end() #36940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mitsos1os wants to merge 3 commits into from
Closed

[v14.x Backport] http: don't cork noop .end() #36940

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71aed6b
test: http complete response after socket double end
mitsos1os Jan 10, 2021
5f944b9
test: assert http writable corked state after end
mitsos1os Jan 15, 2021
dccef0f
http: don't cork .end when not needed
mitsos1os Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: assert http writable corked state after end
  • Loading branch information
@mitsos1os
mitsos1os committed Jan 15, 2021
commit 5f944b98d7c076ec8407bbf1bb4a0788b158f3c8
3 changes: 3 additions & 0 deletions test/parallel/test-http-outgoing-end-multiple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,15 @@ const http = require('http');

const server = http.createServer(common.mustCall(function(req, res) {
res.end('testing ended state', common.mustCall());
assert.strictEqual(res.writableCorked, 0);
res.end(common.mustCall());
assert.strictEqual(res.writableCorked, 0);
res.on('finish', common.mustCall(() => {
res.end(common.mustCall((err) => {
assert.strictEqual(err.code, 'ERR_STREAM_ALREADY_FINISHED');
server.close();
}));
assert.strictEqual(res.writableCorked, 0);
}));
}));

Expand Down