Skip to content

fs: fix busy loop in recursive rm for windows #36815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RaisinTen wants to merge 3 commits into from
Closed

fs: fix busy loop in recursive rm for windows #36815

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5572faa
fs: fix busy loop in recursive rm for windows
RaisinTen Jan 6, 2021
27e573a
fixup! fs: fix busy loop in recursive rm for windows
RaisinTen May 18, 2021
c3c99a5
fixup! fixup! fs: fix busy loop in recursive rm for windows
RaisinTen May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fs: fix busy loop in recursive rm for windows
  • Loading branch information
@RaisinTen
RaisinTen committed May 18, 2021
commit 27e573a2a5d7b8762bd90b321d0d1222f9fd83a1
2 changes: 1 addition & 1 deletion test/parallel/test-recursive-rm-busy-loop-windows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function makeDirectoryWritable(dir) {
if (common.isWindows) {
execSync(`icacls ${dir} /remove:d "everyone"`);
} else {
fs.chmodSync(dirname, 0o777);
fs.chmodSync(dir, 0o777);
}
}

Expand Down