Skip to content

process: passing -1 to setuid/setgid should not abort #36786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 2 commits into from
Closed

process: passing -1 to setuid/setgid should not abort #36786

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30ecea9
process: passing -1 to setuid/setgid should not abort
jasnell Jan 4, 2021
02b9fac
[Squash] ...
jasnell Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Squash] ... 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@jasnell @targos
jasnell and targos authored Jan 6, 2021
commit 02b9facc4c92f9ce154297f1c8af4207394a5758
2 changes: 1 addition & 1 deletion lib/internal/bootstrap/switches/does_own_process_state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ function wrapPosixCredentialSetters(credentials) {
function wrapIdSetter(type, method) {
return function(id) {
validateId(id, 'id');
// Result is 0 on success, 1 if credential is unknown.
if (typeof id === 'number') id |= 0;
// Result is 0 on success, 1 if credential is unknown.
const result = method(id);
if (result === 1) {
throw new ERR_UNKNOWN_CREDENTIAL(type, id);
Expand Down