Skip to content

build: enable sse4.2 and ssse3 in zlib #36693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RaisinTen wants to merge 5 commits into from
Closed

build: enable sse4.2 and ssse3 in zlib #36693

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
23873bf
build: enable sse4.2 in zlib
RaisinTen Dec 30, 2020
c5e62b4
build: enable ssse3 in zlib
RaisinTen Jan 1, 2021
b35ae3b
build: add TODO comments to add -msse2 for zlib
RaisinTen Jan 1, 2021
4289461
build: enable pclmul in zlib
RaisinTen Jan 2, 2021
bc657ec
build: enable sse4.2 and pclmul in zlib
RaisinTen Jan 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions deps/zlib/contrib/optimizations/insert_string.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
// clang-format off
#if defined(CRC32_SIMD_SSE42_PCLMUL)
/* Required to make MSVC bot build pass. */
// TODO(raisinten): When https://github.com/nodejs/node/pull/33044 lands,
// remove the next line and add `-msse4.2` to the command line options.
Copy link
Copy Markdown
Member

@jasnell jasnell Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this lands before #33044, a commit should be added to that PR that resolves this TODO.

Copy link
Copy Markdown
Member Author

@RaisinTen RaisinTen Jan 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @richardlau
Please consider adding these options in your PR if you haven't added them already. :)

#pragma GCC target ("sse4.2")
#include <smmintrin.h>
#if defined(__GNUC__) || defined(__clang__)
#undef TARGET_CPU_WITH_CRC
Expand Down