Skip to content

stream: fix pipe deadlock when starting with needDrain #36563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 4 commits into from
Closed

stream: fix pipe deadlock when starting with needDrain #36563

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0af4317
stream: fix pipe deadlock when starting with needDrain
ronag Dec 18, 2020
0996479
fixup
ronag Dec 18, 2020
fcc9351
fixup
ronag Dec 18, 2020
b37e0df
fixup
ronag Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@ronag
ronag committed Dec 18, 2020
commit 099647968c46ef00b7cac96d8728ab077ff39173
11 changes: 7 additions & 4 deletions test/parallel/test-stream-pipe-needDrain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ const assert = require('assert');
const Readable = require('_stream_readable');
const Writable = require('_stream_writable');

// Pipe should not continue writing if writable needs drain.
// Pipe should pause temporarily if writable needs drain.
{
const w = new Writable({
write(buf, encoding, callback) {

}
process.nextTick(callback);
},
highWaterMark: 1
});

while (w.write('asd'));
Expand All @@ -20,10 +21,12 @@ const Writable = require('_stream_writable');
const r = new Readable({
read() {
this.push('asd');
this.push(null);
}
});

w.write = common.mustNotCall();
r.on('pause', common.mustCall());
r.on('end', common.mustCall());

r.pipe(w);
}