Skip to content

worker: implement Web Locks API #36502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 8 commits into from
Closed

worker: implement Web Locks API #36502

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
84ab409
worker: implement Web Locks API
addaleax Dec 13, 2020
949b24d
fixup! worker: implement Web Locks API
addaleax Dec 13, 2020
87feb3a
test: add web-locks WPT
targos Dec 14, 2020
0fed56d
fixup! worker: implement Web Locks API
addaleax Dec 14, 2020
a4f7cf0
fixup! worker: implement Web Locks API
addaleax Dec 14, 2020
0403239
fixup! test: add web-locks WPT
addaleax Dec 14, 2020
f30da92
fixup! worker: implement Web Locks API
aduh95 Dec 15, 2020
3eaa2ce
fixup! worker: implement Web Locks API
aduh95 Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! worker: implement Web Locks API
  • Loading branch information
@addaleax
addaleax committed Dec 14, 2020
commit a4f7cf009f51222ab8bcefd7adacde14b05ab91e
26 changes: 18 additions & 8 deletions lib/internal/worker/locks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ const {
onclose_message_symbol,
} = internalBinding('symbols');
const assert = require('internal/assert');
const {
ERR_INVALID_ARG_VALUE
Comment thread
aduh95 marked this conversation as resolved.
Outdated
} = require('internal/errors');
const {
SafeMap,
SymbolToStringTag,
Expand Down Expand Up @@ -415,24 +418,31 @@ class LockManager {
if (name.startsWith('-')) {
// If name starts with U+002D HYPHEN-MINUS (-), then reject promise with a
// "NotSupportedError" DOMException.
throw new DOMException('NotSupportedError');
throw new DOMException('Lock name may not start with hyphen',
'NotSupportedError');
} else if (options.ifAvailable === true && options.steal === true) {
// Otherwise, if both options' steal dictionary member and option's
// ifAvailable dictionary member are true, then reject promise with a
// "NotSupportedError" DOMException.
throw new DOMException('NotSupportedError');
} else if (options.steal === true && options.mode !== 'exclusive') {
// Otherwise, if options' steal dictionary member is true and option's
// mode dictionary member is not "exclusive", then reject promise with a
// "NotSupportedError" DOMException.
throw new DOMException('NotSupportedError');
throw new DOMException('ifAvailable and steal are mutually exclusive',
'NotSupportedError');
} else if (options.mode !== 'shared' && options.mode !== 'exclusive') {
throw new ERR_INVALID_ARG_VALUE.TypeError(
'mode must be "shared" or "exclusive"');
} else if (options.mode !== 'exclusive' && options.steal === true) {
// If options' steal dictionary member is true and options' mode
// dictionary member is not "exclusive", then return a promise rejected
// with a "NotSupportedError" DOMException.
throw new DOMException('mode: "shared" and steal are mutually exclusive',
'NotSupportedError');
} else if (options.signal &&
(options.steal === true || options.ifAvailable === true)) {
// If options' signal dictionary member is present, and either of
// options' steal dictionary member or options' ifAvailable dictionary
// member is true, then return a promise rejected with a
// "NotSupportedError" DOMException.
throw new DOMException('NotSupportedError');
throw new DOMException('signal cannot be used with steal or ifAvailable',
'NotSupportedError');
} else if (options.signal && options.signal.aborted) {
throw new DOMException('The operation was aborted', 'AbortError');
}
Expand Down