Skip to content

doc: make explicit reverting node_version.h changes #36461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardlau wants to merge 2 commits into from
Closed

doc: make explicit reverting node_version.h changes #36461

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61f69fb
doc: make explicit reverting node_version.h changes
richardlau Dec 9, 2020
af347d6
fixup! doc: make explicit reverting node_version.h changes
richardlau Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: make explicit reverting node_version.h changes 
Add an explicit command to revert changes to `node_version.h` when
cherry-picking the release commit to the `master` branch.
  • Loading branch information
@richardlau
richardlau committed Dec 9, 2020
commit 61f69fb8ac9193c5cfcba5e2ff67263c0576ff40
8 changes: 7 additions & 1 deletion doc/guides/releases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,13 @@ $ git cherry-pick v1.x^
```

Git should stop to let you fix conflicts. Revert all changes that were made to
`src/node_version.h`. If there are conflicts in `doc` due to updated `REPLACEME`
`src/node_version.h`:

```console
$ git checkout --ours -- src/node_version.h
```

If there are conflicts in `doc` due to updated `REPLACEME`
placeholders (that happens when a change previously landed on another release
branch), keep both version numbers. Convert the YAML field to an array if it is
not already one.
Expand Down