Skip to content

src: add typedef for CleanupHookCallback callback #36442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 2 commits into from
Closed

src: add typedef for CleanupHookCallback callback #36442

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88c83ad
src: add typedef for CleanupHookCallback callback
danbev Dec 8, 2020
0c833d4
squash! src: add typedef for CleanupHookCallback callback
danbev Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash! src: add typedef for CleanupHookCallback callback 
Update AddCleanupHook and RemoveCleanupHook in env-inl.h.
  • Loading branch information
@danbev
danbev committed Dec 8, 2020
commit 0c833d469ef314ae4915f6a7feed8b7bde46e9b8
4 changes: 2 additions & 2 deletions src/env-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1024,15 +1024,15 @@ inline void Environment::SetInstanceMethod(v8::Local<v8::FunctionTemplate> that,
t->SetClassName(name_string);
}

void Environment::AddCleanupHook(void (*fn)(void*), void* arg) {
void Environment::AddCleanupHook(CleanupCallback fn, void* arg) {
auto insertion_info = cleanup_hooks_.emplace(CleanupHookCallback {
fn, arg, cleanup_hook_counter_++
});
// Make sure there was no existing element with these values.
CHECK_EQ(insertion_info.second, true);
}

void Environment::RemoveCleanupHook(void (*fn)(void*), void* arg) {
void Environment::RemoveCleanupHook(CleanupCallback fn, void* arg) {
CleanupHookCallback search { fn, arg, 0 };
cleanup_hooks_.erase(search);
}
Expand Down