Skip to content

stream: support AbortSignal in constructor #36431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjamingr wants to merge 3 commits into from
Closed

stream: support AbortSignal in constructor #36431

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03ff368
stream: support abortsignal in constructor
benjamingr Dec 7, 2020
1b3e4d1
fixup! default behaviour
benjamingr Dec 7, 2020
47bd0e7
fixup! code review
benjamingr Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! default behaviour
  • Loading branch information
@benjamingr
benjamingr committed Dec 7, 2020
commit 1b3e4d1d6a8ad1205324fae907d296e10b00ca68
3 changes: 3 additions & 0 deletions lib/internal/streams/add-abort-signal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ module.exports.addAbortSignal = function addAbortSignal(signal, stream) {
return module.exports.addAbortSignalNoValidate(signal, stream);
};
module.exports.addAbortSignalNoValidate = function(signal, stream) {
Comment thread
benjamingr marked this conversation as resolved.
if (!signal) {
Comment thread
benjamingr marked this conversation as resolved.
Outdated
return stream;
}
const onAbort = () => {
stream.destroy(new AbortError());
};
Expand Down