Skip to content

lib: make safe primordials safe to iterate #36391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 11 commits into from
Closed

lib: make safe primordials safe to iterate #36391

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6e218f9
lib: make safe primordials safe to iterate
aduh95 Dec 4, 2020
cc40d41
fixup! lib: make safe primordials safe to iterate
aduh95 Dec 5, 2020
0e6ecc0
fixup! lib: make safe primordials safe to iterate
aduh95 Dec 6, 2020
6a4e2ab
fixup! lib: make safe primordials safe to iterate
aduh95 Dec 6, 2020
cf53748
fixup! lib: make safe primordials safe to iterate
aduh95 Dec 7, 2020
3939f68
fixup! lib: make safe primordials safe to iterate
aduh95 Dec 8, 2020
28a2218
fixup! lib: make safe primordials safe to iterate
aduh95 Dec 11, 2020
4b87c3b
fixup! lib: make safe primordials safe to iterate
aduh95 Dec 11, 2020
036ff05
fixup! lib: make safe primordials safe to iterate
aduh95 Dec 12, 2020
c90d0ca
fixup! lib: make safe primordials safe to iterate
aduh95 Dec 12, 2020
1691a88
fixup! lib: make safe primordials safe to iterate
aduh95 Dec 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! lib: make safe primordials safe to iterate
  • Loading branch information
@aduh95
aduh95 committed Dec 7, 2020
commit cf5374855af25ca9da5e8446f40f949ebb7e0826
9 changes: 5 additions & 4 deletions lib/internal/per_context/primordials.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,7 @@ const createSafeIterator = (factory, next) => {
Object.setPrototypeOf(SafeIterator.prototype, null);
Object.freeze(SafeIterator.prototype);
Object.freeze(SafeIterator);
return function() {
return new SafeIterator(this);
};
return SafeIterator;
};

function makeSafe(unsafe, safe) {
Expand All @@ -95,7 +93,10 @@ function makeSafe(unsafe, safe) {
if (Symbol.iterator in unsafe.prototype) {
const createIterator = uncurryThis(unsafe.prototype[Symbol.iterator]);
const next = uncurryThis(createIterator(new unsafe()).next);
safe.prototype[Symbol.iterator] = createSafeIterator(createIterator, next);
const SafeIterator = createSafeIterator(createIterator, next);
safe.prototype[Symbol.iterator] = function() {
return new SafeIterator(this);
};
}
Object.setPrototypeOf(safe.prototype, null);
Object.freeze(safe.prototype);
Expand Down