Skip to content

vm: add SafeForTerminationScopes for SIGINT interruptions #36344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

vm: add SafeForTerminationScopes for SIGINT interruptions #36344

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7449ba3
vm: add `SafeForTerminationScope`s for SIGINT interruptions
addaleax Dec 1, 2020
8bb62dc
fixup! vm: add `SafeForTerminationScope`s for SIGINT interruptions
addaleax Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! vm: add SafeForTerminationScopes for SIGINT interruptions
  • Loading branch information
@addaleax
addaleax committed Dec 2, 2020
commit 8bb62dc4300136705af6b156ec269cbaa6438ea3
6 changes: 3 additions & 3 deletions test/cctest/test_environment.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ TEST_F(EnvironmentTest, SetImmediateMicrotasks) {
TEST_F(NodeZeroIsolateTestFixture, CtrlCWithOnlySafeTerminationTest) {
// We need to go through the whole setup dance here because we want to
// set only_terminate_in_safe_scope.
// Allocate and initialize isolate
// Allocate and initialize Isolate.
v8::Isolate::CreateParams create_params;
create_params.array_buffer_allocator = allocator.get();
create_params.only_terminate_in_safe_scope = true;
Expand All @@ -563,7 +563,7 @@ TEST_F(NodeZeroIsolateTestFixture, CtrlCWithOnlySafeTerminationTest) {
platform->RegisterIsolate(isolate, &current_loop);
v8::Isolate::Initialize(isolate, create_params);

// Try creating Context + IsolateData + Environment
// Try creating Context + IsolateData + Environment.
{
v8::Isolate::Scope isolate_scope(isolate);
v8::HandleScope handle_scope(isolate);
Expand Down Expand Up @@ -603,7 +603,7 @@ TEST_F(NodeZeroIsolateTestFixture, CtrlCWithOnlySafeTerminationTest) {
EXPECT_EQ(std::string(*main_ret_str), "ERR_SCRIPT_EXECUTION_INTERRUPTED");
}

// Cleanup
// Cleanup.
platform->UnregisterIsolate(isolate);
isolate->Dispose();
}
Expand Down