Skip to content

doc: add note about timingSafeEqual for TypedArray #36323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 2 commits into from
Closed

doc: add note about timingSafeEqual for TypedArray #36323

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89b0d23
doc: add note about timingSafeEqual for TypedArray
tniessen Nov 30, 2020
dd16890
fixup
tniessen Dec 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup 
Thanks Anna!
  • Loading branch information
@tniessen
tniessen authored Dec 12, 2020
commit dd16890f0c882df58d5420dc2cf0d619e2faad0c
5 changes: 3 additions & 2 deletions doc/api/crypto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3385,8 +3385,9 @@ comparing HMAC digests or secret values like authentication cookies or
`a` and `b` must both be `Buffer`s, `TypedArray`s, or `DataView`s, and they
must have the same byte length.

If at least one of `a` and `b` is a `TypedArray`, the result may depend on
the platform byte order.
If at least one of `a` and `b` is a `TypedArray` with more than one byte per
entry, such as `Uint16Array`, the result will be computed using the platform
byte order.

Use of `crypto.timingSafeEqual` does not guarantee that the *surrounding* code
is timing-safe. Care should be taken to ensure that the surrounding code does
Expand Down