Skip to content

net: refactor to use more primordials #36303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 4 commits into from
Closed

net: refactor to use more primordials #36303

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01859db
net: refactor to use more primordials
aduh95 Nov 17, 2020
d4128fd
fixup! net: refactor to use more primordials
aduh95 Nov 28, 2020
a9fe755
fixup! net: refactor to use more primordials
aduh95 Nov 28, 2020
7a938d6
fixup! net: refactor to use more primordials
aduh95 Nov 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! net: refactor to use more primordials 
This reverts commit a9fe755.
  • Loading branch information
@aduh95
aduh95 committed Nov 28, 2020
commit 7a938d640db024e1c0efb532ac6516cc786ffb9d
8 changes: 4 additions & 4 deletions lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ function Socket(options) {
options.autoDestroy = true;
// Handle strings directly.
options.decodeStrings = false;
ReflectApply(stream.Duplex, this, arguments);
ReflectApply(stream.Duplex, this, [options]);

if (options.handle) {
this._handle = options.handle; // private
Expand Down Expand Up @@ -442,7 +442,7 @@ function afterShutdown() {
function writeAfterFIN(chunk, encoding, cb) {
if (!this.writableEnded) {
return ReflectApply(
stream.Duplex.prototype.write, this, arguments);
stream.Duplex.prototype.write, this, [chunk, encoding, cb]);
}

if (typeof encoding === 'function') {
Expand Down Expand Up @@ -586,7 +586,7 @@ Socket.prototype._read = function(n) {


Socket.prototype.end = function(data, encoding, callback) {
ReflectApply(stream.Duplex.prototype.end, this, arguments);
ReflectApply(stream.Duplex.prototype.end, this, [data, encoding, callback]);
DTRACE_NET_STREAM_END(this);
return this;
};
Expand Down Expand Up @@ -620,7 +620,7 @@ Socket.prototype.read = function(n) {
!this._handle.reading) {
tryReadStart(this);
}
return ReflectApply(stream.Duplex.prototype.read, this, arguments);
return ReflectApply(stream.Duplex.prototype.read, this, [n]);
};


Expand Down