Skip to content

lib: restate the code to use primordials #36294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PoojaDurgad wants to merge 2 commits into from
Closed

lib: restate the code to use primordials #36294

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6ba8aa
lib: restate the code to use primordials
PoojaDurgad Nov 27, 2020
9201949
fixup: revert the changes
PoojaDurgad Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: revert the changes
  • Loading branch information
@PoojaDurgad
PoojaDurgad committed Nov 30, 2020
commit 9201949674ac57faa12688d99b4638116bb17784
5 changes: 2 additions & 3 deletions lib/_http_common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@

const {
MathMin,
RegExpPrototypeTest,
Symbol,
} = primordials;
const { setImmediate } = require('timers');
Expand Down Expand Up @@ -218,7 +217,7 @@ const tokenRegExp = /^[\^_`a-zA-Z\-0-9!#$%&'*+.|~]+$/;
* See https://tools.ietf.org/html/rfc7230#section-3.2.6
*/
function checkIsHttpToken(val) {
return RegExpPrototypeTest(tokenRegExp, val);
return tokenRegExp.test(val);
}

const headerCharRegex = /[^\t\x20-\x7e\x80-\xff]/;
Expand All @@ -229,7 +228,7 @@ const headerCharRegex = /[^\t\x20-\x7e\x80-\xff]/;
* field-vchar = VCHAR / obs-text
*/
function checkInvalidHeaderChar(val) {
return RegExpPrototypeTest(headerCharRegex, val);
return headerCharRegex.test(val);
}

function cleanParser(parser) {
Expand Down