Skip to content

doc: add table header in intl.md #36261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Nov 28, 2020
Merged

doc: add table header in intl.md #36261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: add table header in intl.md 
An empty header element in a table is an accessibility issue. In this
case, specifying the column as containing a feature seems to be the way
to go.

PR-URL: #36261
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@Trott
Trott committed Nov 28, 2020
commit 0ac2d0fafd2ce9aa451802f8b53d7d809939c1da
2 changes: 1 addition & 1 deletion doc/api/intl.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ in [BUILDING.md][].
An overview of available Node.js and JavaScript features for each `configure`
option:

| | `none` | `system-icu` | `small-icu` | `full-icu` |
| Feature | `none` | `system-icu` | `small-icu` | `full-icu` |
|-----------------------------------------|-----------------------------------|------------------------------|------------------------|------------|
| [`String.prototype.normalize()`][] | none (function is no-op) | full | full | full |
| `String.prototype.to*Case()` | full | full | full | full |
Expand Down