Skip to content

test: make test-http2-client-jsstream-destroy.js reliable #36129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Nov 17, 2020
+7 −4
Merged

test: make test-http2-client-jsstream-destroy.js reliable #36129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: make test-http2-client-jsstream-destroy.js reliable 
Use events instead of setTimeout() calls.

Fixes: #36078

PR-URL: #36129
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
  • Loading branch information
@Trott
Trott committed Nov 17, 2020
commit fff25a0714576f7f92c73111bab1c63219812da0
11 changes: 7 additions & 4 deletions test/parallel/test-http2-client-jsstream-destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,13 @@ server.listen(0, common.mustCall(function() {
});
const req = client.request();

setTimeout(() => socket.destroy(), common.platformTimeout(100));
setTimeout(() => client.close(), common.platformTimeout(200));
setTimeout(() => server.close(), common.platformTimeout(300));
server.on('request', () => {
socket.destroy();
});

req.on('close', common.mustCall(() => { }));
req.on('close', common.mustCall(() => {
Comment thread
Trott marked this conversation as resolved.
Outdated
client.close();
server.close();
}));
});
}));