Skip to content

http2: add support for AbortSignal to http2Session.request #36070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MadaraUchiha wants to merge 9 commits into from
Closed

http2: add support for AbortSignal to http2Session.request #36070

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ba7f38b
http2: add support for AbortSignal to http2Session.request
MadaraUchiha Nov 10, 2020
aec2c2b
http2: Document AbortSignalSupport
MadaraUchiha Nov 10, 2020
a88f87b
http2: Fix lint errors
MadaraUchiha Nov 10, 2020
90ab360
http2: Remove redundant empty line in docs
MadaraUchiha Nov 10, 2020
2cd337e
http2: Use existing signal constant
MadaraUchiha Nov 10, 2020
05f68a2
http2: Goodify test
MadaraUchiha Nov 10, 2020
dc99724
http2: Abort calls destroy with an AbortError
MadaraUchiha Nov 19, 2020
3d5177d
http2: Update documentation
MadaraUchiha Nov 19, 2020
9aca7c4
http2: Abort immediately if passed an already aborted signal
MadaraUchiha Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http2: Update documentation 
- Calling abort no longer behaves like .destroy()
- Fix linting errors
  • Loading branch information
@MadaraUchiha
MadaraUchiha committed Nov 21, 2020
commit 3d5177ddfc3a1dc41a1d23acdef63b1a279b4733
6 changes: 3 additions & 3 deletions doc/api/http2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,9 +887,9 @@ close when the final `DATA` frame is transmitted. User code must call either
`http2stream.sendTrailers()` or `http2stream.close()` to close the
`Http2Stream`.

When `options.signal` is set with an `AbortSignal` and then calling `abort` on
the corresponding `AbortController` will behave the same way as calling
`.destroy()` on the request itself.
When `options.signal` is set with an `AbortSignal` and then `abort` on the
corresponding `AbortController` is called, the request will emit an `'error'`
event with an `AbortError` error.

The `:method` and `:path` pseudo-headers are not specified within `headers`,
they respectively default to:
Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-http2-client-destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,23 +178,23 @@ const Countdown = require('../common/countdown');
server.listen(0, common.mustCall(() => {
const client = h2.connect(`http://localhost:${server.address().port}`);
client.on('close', common.mustCall());

const { signal } = controller;
assert.strictEqual(signal[kEvents].get('abort'), undefined);

client.on('error', common.mustCall(() => {
// After underlying stream dies, signal listener detached
// After underlying stream dies, signal listener detached
assert.strictEqual(signal[kEvents].get('abort'), undefined);
}));

const req = client.request({}, { signal });

req.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ABORT_ERR');
assert.strictEqual(err.name, 'AbortError');
}));
req.on('close', common.mustCall(() => server.close()));

assert.strictEqual(req.aborted, false);
assert.strictEqual(req.destroyed, false);
// Signal listener attached
Expand Down