Skip to content

test: fix error in test/internet/test-dns.js #35969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Nov 5, 2020
Merged

test: fix error in test/internet/test-dns.js #35969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix error in test/internet/test-dns.js 
Refs: #35466 (comment)

PR-URL: #35969
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@Trott
Trott committed Nov 5, 2020
commit 088dfce77702e0027fd025afc53a28825ae6c48d
3 changes: 2 additions & 1 deletion test/internet/test-dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,8 @@ TEST(function test_resolveSoa_failure(done) {

TEST(async function test_resolveCaa(done) {
function validateResult(result) {
assert.ok(Array.isArray(result[0]));
assert.ok(Array.isArray(result),
`expected array, got ${util.inspect(result)}`);
assert.strictEqual(result.length, 1);
assert.strictEqual(typeof result[0].critical, 'number');
assert.strictEqual(result[0].critical, 0);
Expand Down