Skip to content

test: correct test-worker-eventlooputil #35891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Flarna wants to merge 3 commits into from
Closed

test: correct test-worker-eventlooputil #35891

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ea3b8d
test: correct test-worker-eventlooputil
Flarna Oct 31, 2020
4374323
fixup! test: correct test-worker-eventlooputil
Flarna Nov 2, 2020
932350e
fixup! test: correct test-worker-eventlooputil
Flarna Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: correct test-worker-eventlooputil 
The active worker check compared the time from sending message till
response arrived from worker with the complete time the worker was
running till it responses to the spin request.

If sending back the message is slow for some reason the test fails.

Adapt the test to compare the time seen inside the worker with the
time read from main thread.
  • Loading branch information
@Flarna
Flarna committed Oct 31, 2020
commit 4ea3b8d9d5daec614eb504fbae769fe88586325a
8 changes: 5 additions & 3 deletions test/parallel/test-worker-eventlooputil.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ function workerOnMetricsMsg(msg) {
}

if (msg.cmd === 'spin') {
const elu = eventLoopUtilization();
const t = now();
while (now() - t < msg.dur);
return this.postMessage(eventLoopUtilization());
return this.postMessage(eventLoopUtilization(elu));
Comment thread
Flarna marked this conversation as resolved.
}
}

Expand Down Expand Up @@ -104,8 +105,9 @@ function checkWorkerActive() {
const w2 = workerELU(w);

assert.ok(w2.active >= 50, `${w2.active} < 50`);
assert.ok(idleActive(wElu) > idleActive(w2),
`${idleActive(wElu)} <= ${idleActive(w2)}`);
assert.ok(wElu.active >= 50, `${wElu.active} < 50`);
assert.ok(idleActive(wElu) < idleActive(w2),
Comment thread
Flarna marked this conversation as resolved.
`${idleActive(wElu)} > ${idleActive(w2)}`);

metricsCh.port2.postMessage({ cmd: 'close' });
});
Expand Down