Skip to content

n-api: revert change to finalisation #35777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 2 commits into from
+8 −4
Closed

n-api: revert change to finalisation #35777

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f46eaa
n-api: revert change to finalization
mhdawson Oct 23, 2020
3769505
Update test/node-api/test_worker_terminate_finalization/test.js
mhdawson Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test/node-api/test_worker_terminate_finalization/test.js
  • Loading branch information
@mhdawson
mhdawson authored Oct 26, 2020
commit 3769505233a578e0429696314a6050d87b829b29
2 changes: 2 additions & 0 deletions test/node-api/test_worker_terminate_finalization/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ const common = require('../../common');

// TODO(addaleax): Run this test once it stops failing under ASAN/valgrind.
// Refs: https://github.com/nodejs/node/issues/34731
Copy link
Copy Markdown
Member

@Trott Trott Oct 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional non-blocking suggestion: Should the comment mention #35778 as well? And maybe #35777 (this pull request) too?

Comment thread
mhdawson marked this conversation as resolved.
// Refs: https://github.com/nodejs/node/pull/35777
// Refs: https://github.com/nodejs/node/issues/35778
common.skip('Reference management in N-API leaks memory');

const { Worker, isMainThread } = require('worker_threads');
Expand Down