Skip to content

lib: return boolean from child.send() #3577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

lib: return boolean from child.send() #3577

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f24c29f
lib: return boolean from child.send()
Trott Oct 25, 2015
b904c2f
fixup
Trott Oct 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lib: return boolean from child.send() 
Previous change reinstated returning boolean from child.send() but
missed one instance where undefined might be returned instead.
  • Loading branch information
@Trott
Trott committed Oct 29, 2015
commit f24c29fe9c998f7ad82a18e5a7fb222b44a6b75f
2 changes: 1 addition & 1 deletion lib/internal/child_process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ function setupChannel(target, channel) {
handle: handle,
message: message.msg,
});
return;
return this._handleQueue.length === 1;
}

var obj = handleConversion[message.type];
Expand Down
22 changes: 21 additions & 1 deletion test/parallel/test-child-process-send-returns-boolean.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,29 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const path = require('path');
const net = require('net');
const fork = require('child_process').fork;
const spawn = require('child_process').spawn;

const n = fork(common.fixturesDir + '/empty.js');
const emptyFile = path.join(common.fixturesDir, 'empty.js');

const n = fork(emptyFile);

const rv = n.send({ hello: 'world' });
assert.strictEqual(rv, true);

const s = spawn(process.execPath, [emptyFile],
{ stdio: ['pipe', 'pipe', 'pipe', 'ipc'] });
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Oct 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: argument should line up.

var handle = null;
s.on('exit', function() {
handle.close();
});

net.createServer(common.fail).listen(common.PORT, function() {
handle = this._handle;
assert.strictEqual(s.send('one', handle), true);
assert.strictEqual(s.send('two', handle), true);
assert.strictEqual(s.send('three'), false);
assert.strictEqual(s.send('four'), false);
});