Skip to content

http2: reinject data received before http2 is attached #35678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmomtchev wants to merge 2 commits into from
Closed

http2: reinject data received before http2 is attached #35678

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2374d7
http2: reinject data received before http2 is attached
mmomtchev Oct 16, 2020
e36b31c
http2: fix reinjection check
mmomtchev Oct 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
http2: fix reinjection check 
We reinject when the sockets has already waiting
data, remarked by @mildsunrise

Co-authored-by: Alba Mendez <me@alba.sh>
  • Loading branch information
@mmomtchev @mildsunrise
mmomtchev and mildsunrise authored Oct 18, 2020
commit e36b31c1bc4292085e10d2f019a1a046076cfc2c
2 changes: 1 addition & 1 deletion lib/internal/http2/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3132,7 +3132,7 @@ function connect(authority, options, listener) {
debug('Http2Session connect', options.createConnection);
// Socket already has some buffered data - emulate receiving it
// https://github.com/nodejs/node/issues/35475
if (typeof options.createConnection === 'function') {
if (socket && socket.readableLength) {
let buf;
while ((buf = socket.read()) !== null) {
debug(`Http2Session connect: injecting ${buf.length} already in buffer`);
Expand Down