Skip to content

test: add windows and c++ coverage #35670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcoe wants to merge 12 commits into from
+82 −9
Closed

test: add windows and c++ coverage #35670

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
df981ea
test: add windows and C++ coverage
Oct 17, 2020
d91b81d
build: improve coverage configuration
Oct 18, 2020
656160f
chore: attempt to build with gcov
Oct 18, 2020
9eac50b
build: ensure gcovr tool exists
Oct 18, 2020
f869255
chore: tweak codecov.yml file
Oct 18, 2020
f5d6272
multi-line command had issues
Oct 18, 2020
40cb785
chore: delete more output files
Oct 18, 2020
fc7c05c
build: run test-cov rather than test-ci
Oct 18, 2020
5939514
chore: address review
Oct 20, 2020
71f998a
chore: fiddle with gcovr settings
Oct 20, 2020
15d170e
chore: simplify command
Oct 20, 2020
c646f6d
build: a couple more small tweaks to reports
Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: run test-cov rather than test-ci
  • Loading branch information
bcoe committed Oct 18, 2020
commit fc7c05c356531de604155bf7030721df058c0940
2 changes: 1 addition & 1 deletion .github/workflows/coverage-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
# TODO(bcoe): fix the couple tests that fail with the inspector enabled.
# The cause is most likely coverage's use of the inspector.
- name: Test
run: NODE_V8_COVERAGE=coverage/tmp make run-ci -j2 V=1 TEST_CI_ARGS="-p dots" || exit 0
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j2 V=1 TEST_CI_ARGS="-p dots" || exit 0
- name: Report js
run: npx c8 report --check-coverage
- name: Report C++
Expand Down