Skip to content

fix: ftruncate for negative and maximum values #35645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IgorHalfeld wants to merge 6 commits into from
Closed

fix: ftruncate for negative and maximum values #35645

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
41ca10a
fix ftruncate for negative and maximum values
IgorHalfeld Oct 14, 2020
9694783
put same validation for async ftruncate
IgorHalfeld Oct 14, 2020
e861776
remove unused var MathMax from lib/fs.js
IgorHalfeld Oct 14, 2020
7688f6c
change error type when parameter is not valid for ftruncate
IgorHalfeld Oct 14, 2020
ffb1861
put required arg on ERR_INVALID_ARG_VALUE
IgorHalfeld Oct 15, 2020
e04fd9b
fix tests for ftruncate
IgorHalfeld Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
put required arg on ERR_INVALID_ARG_VALUE
  • Loading branch information
@IgorHalfeld
IgorHalfeld committed Dec 11, 2020
commit ffb18618b34a89d3751627c5da26754142eac6da
4 changes: 2 additions & 2 deletions lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,7 +846,7 @@ function ftruncate(fd, len = 0, callback) {
validateInteger(len, 'len');

if (len < 0) {
throw new ERR_INVALID_ARG_VALUE(len);
throw new ERR_INVALID_ARG_VALUE('len', len);
}

callback = makeCallback(callback);
Expand All @@ -861,7 +861,7 @@ function ftruncateSync(fd, len = 0) {
validateInteger(len, 'len');

if (len < 0) {
throw new ERR_INVALID_ARG_VALUE(len);
throw new ERR_INVALID_ARG_VALUE('len', len);
}

const ctx = {};
Expand Down