Skip to content

[v14.x] Revert "tools: add missing uv_setup_argv() calls" #35641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BethGriggs wants to merge 1 commit into from
Closed

[v14.x] Revert "tools: add missing uv_setup_argv() calls" #35641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "tools: add missing uv_setup_argv() calls" 
This reverts commit 70e77f123164ecbdbdd4abc2e4919ce1b193421e.
  • Loading branch information
@BethGriggs
BethGriggs committed Oct 14, 2020
commit c9b5b566e3fec36fe95b9f6ac31ee2bef17f0a5a
1 change: 0 additions & 1 deletion tools/code_cache/mkcodecache.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ using v8::Local;
int wmain(int argc, wchar_t* argv[]) {
#else // UNIX
int main(int argc, char* argv[]) {
argv = uv_setup_args(argc, argv);
#endif // _WIN32

v8::V8::SetFlagsFromString("--random_seed=42");
Expand Down
1 change: 0 additions & 1 deletion tools/snapshot/node_mksnapshot.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
int wmain(int argc, wchar_t* argv[]) {
#else // UNIX
int main(int argc, char* argv[]) {
argv = uv_setup_args(argc, argv);
#endif // _WIN32

v8::V8::SetFlagsFromString("--random_seed=42");
Expand Down