test: improve error message for policy failures

nodejs · bmeck · Oct 13, 2020 · Oct 13, 2020 · Oct 15, 2020 · Oct 15, 2020
commit 8c14f61f24208a4a18ece198bdcade399fd976f8
diff --git a/test/common/index.js b/test/common/index.js
@@ -697,6 +697,22 @@ function gcUntil(name, condition) {
   });
 }
 
+function requireNoPackageJSONAbove() {
+  let possiblePackage = path.join(__dirname, '..', 'package.json');
+  let lastPackage = null;
+  while (possiblePackage !== lastPackage) {
+    if (fs.existsSync(possiblePackage)) {
+      throw new Error(
+        'This test shouldn\'t load properties from a package.json above ' +
+        `it's file location. Found package.json at ${possiblePackage}, ` +
+        'in order to run this test properly ensure no package.json is above ' +
+        'the tests.');
+    }
+    lastPackage = possiblePackage;
+    possiblePackage = path.join(possiblePackage, '..', '..', 'package.json');
+  }
+}
+
 const common = {
   allowGlobals,
   buildType,
@@ -736,6 +752,7 @@ const common = {
   platformTimeout,
   printSkipMessage,
   pwdCommand,
+  requireNoPackageJSONAbove,
   runWithInvalidFD,
   skip,
   skipIf32Bits,

diff --git a/test/parallel/test-policy-dependencies.js b/test/parallel/test-policy-dependencies.js
@@ -3,6 +3,7 @@
 const common = require('../common');
 if (!common.hasCrypto)
   common.skip('missing crypto');
+common.requireNoPackageJSONAbove();
 
 const fixtures = require('../common/fixtures');
 

diff --git a/test/parallel/test-policy-dependency-conditions.js b/test/parallel/test-policy-dependency-conditions.js
@@ -4,6 +4,7 @@
 const common = require('../common');
 
 if (!common.hasCrypto) common.skip('missing crypto');
+common.requireNoPackageJSONAbove();
 
 const Manifest = require('internal/policy/manifest').Manifest;
 

diff --git a/test/parallel/test-policy-integrity-flag.js b/test/parallel/test-policy-integrity-flag.js
@@ -3,6 +3,7 @@
 const common = require('../common');
 if (!common.hasCrypto)
   common.skip('missing crypto');
+common.requireNoPackageJSONAbove();
 
 const fixtures = require('../common/fixtures');
 

diff --git a/test/parallel/test-policy-parse-integrity.js b/test/parallel/test-policy-parse-integrity.js
@@ -2,6 +2,7 @@
 
 const common = require('../common');
 if (!common.hasCrypto) common.skip('missing crypto');
+common.requireNoPackageJSONAbove();
 
 const tmpdir = require('../common/tmpdir');
 const assert = require('assert');

diff --git a/test/parallel/test-policy-scopes-integrity.js b/test/parallel/test-policy-scopes-integrity.js
@@ -4,6 +4,7 @@
 const common = require('../common');
 
 if (!common.hasCrypto) common.skip('missing crypto');
+common.requireNoPackageJSONAbove();
 
 const Manifest = require('internal/policy/manifest').Manifest;
 const assert = require('assert');

diff --git a/test/parallel/test-policy-scopes.js b/test/parallel/test-policy-scopes.js
@@ -3,6 +3,7 @@
 const common = require('../common');
 if (!common.hasCrypto)
   common.skip('missing crypto');
+common.requireNoPackageJSONAbove();
 
 const fixtures = require('../common/fixtures');
 

diff --git a/test/pummel/test-policy-integrity.js b/test/pummel/test-policy-integrity.js
@@ -2,6 +2,7 @@
 
 const common = require('../common');
 if (!common.hasCrypto) common.skip('missing crypto');
+common.requireNoPackageJSONAbove();
 
 const { debuglog } = require('util');
 const debug = debuglog('test');