Skip to content

test: update url test for win #35622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
watilde wants to merge 2 commits into from
Closed

test: update url test for win #35622

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5b630a
test: update url test for win
watilde Oct 12, 2020
b91224f
bootstrap: use file URL instead of relative url
watilde Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: update url test for win
  • Loading branch information
@watilde
watilde committed Oct 12, 2020
commit c5b630ad64b69d2c2b6902b604debb5f45c7c1cf
6 changes: 3 additions & 3 deletions test/cctest/test_url.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,15 +136,15 @@ TEST_F(URLTest, FromFilePath) {
#ifdef _WIN32
file_url = URL::FromFilePath("C:\\Program Files\\");
EXPECT_EQ("file:", file_url.protocol());
EXPECT_EQ("/C:/Program%20Files/", file_url.path());
EXPECT_EQ("//C:/Program%20Files/", file_url.path());

file_url = URL::FromFilePath("C:\\a\\b\\c");
EXPECT_EQ("file:", file_url.protocol());
EXPECT_EQ("/C:/a/b/c", file_url.path());
EXPECT_EQ("//C:/a/b/c", file_url.path());
Comment thread
watilde marked this conversation as resolved.

file_url = URL::FromFilePath("b:\\a\\%%.js");
EXPECT_EQ("file:", file_url.protocol());
EXPECT_EQ("/b:/a/%25%25.js", file_url.path());
EXPECT_EQ("//b:/a/%25%25.js", file_url.path());
#else
file_url = URL::FromFilePath("/");
EXPECT_EQ("file:", file_url.protocol());
Expand Down