Skip to content

doc: document rmdir/recursive deprecation #35579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcoe wants to merge 5 commits into from
Closed

doc: document rmdir/recursive deprecation #35579

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33a6326
doc: document rmdir/recursive deprecation
Oct 9, 2020
84d4d64
Update doc/api/deprecations.md
Oct 10, 2020
a0372b2
chore: address code review
Oct 10, 2020
485c01a
docs: link to PR where we introduced deprecation language
Oct 11, 2020
fda0877
docs: should be PR itself
Oct 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: document rmdir/recursive deprecation 
Document deprecation of rmdir/recursive permissive functionality
  • Loading branch information
bcoe committed Oct 9, 2020
commit 33a63261c368c4cd6be47ee22153a559af92ea01
14 changes: 14 additions & 0 deletions doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2655,6 +2655,20 @@ Type: Documentation-only
The [`crypto.Certificate()` constructor][] is deprecated. Use
[static methods of `crypto.Certificate()`][] instead.

### DEP0XXX: `fs.rmdir(path, { recursive: true })`
<!-- YAML
changes:
- version: REPLACME
pr-url: https://github.com/nodejs/node/pull/35562
description: Runtime deprecation.
Comment thread
bcoe marked this conversation as resolved.
Outdated
-->

Type: Documentation-only

`fs.rmdir(path, { recursive: true })` will throw on nonexistent paths, or when
Comment thread
bcoe marked this conversation as resolved.
Outdated
given a file as a target. Use `fs.rm(path, { recursive: true, force: true })`
instead.

[Legacy URL API]: url.md#url_legacy_url_api
[NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
[RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3
Expand Down