Skip to content

fs: rimraf should not recurse on failure #35566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcoe wants to merge 5 commits into from
Closed

fs: rimraf should not recurse on failure #35566

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab8731c
fs: rimraf should not recurse on failure
Oct 9, 2020
c1f8562
chore: run the linter
Oct 9, 2020
3dfc53f
chore: code review
Oct 9, 2020
3ef437b
test: added a test
Oct 11, 2020
0c7e55d
test: rimraf fix seems to have fixed known issue
Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: rimraf fix seems to have fixed known issue
  • Loading branch information
bcoe committed Oct 13, 2020
commit 0c7e55d80cfaaaf2125a1423671a8319511e4e91
3 changes: 1 addition & 2 deletions test/known_issues/known_issues.status
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

prefix known_issues

# If a known issue does not apply to a platform, list the test name in the
Expand Down Expand Up @@ -27,5 +28,3 @@ test-vm-timeout-escape-queuemicrotask: SKIP
# The Raspberry Pis are too slow to run this test.
# See https://github.com/nodejs/build/issues/2227#issuecomment-608334574
test-crypto-authenticated-stream: SKIP
# The bug being checked is that the test never exits.
test-fs-open-no-close: TIMEOUT
7 changes: 0 additions & 7 deletions test/known_issues/test-fs-open-no-close.js → test/parallel/test-fs-open-no-close.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,7 @@
// Failing to close a file should not keep the event loop open.

const common = require('../common');

// This issue only shows up on Raspberry Pi devices in our CI. When this test is
// moved out of known_issues, this check can be removed, as the test should pass
// on all platforms at that point.
const assert = require('assert');
if (process.arch !== 'arm' || process.config.variables.arm_version > 7) {
assert.fail('This test is for Raspberry Pi devices in CI');
}

const fs = require('fs');

Expand Down