Skip to content

src: limit GetProcessTitle() result to 1MB #35492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

src: limit GetProcessTitle() result to 1MB #35492

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ec4407
src: limit GetProcessTitle() result to 1MB
addaleax Oct 4, 2020
dd56158
fixup! src: limit GetProcessTitle() result to 1MB
addaleax Oct 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: limit GetProcessTitle() result to 1MB 
`GetProcessTitle()` otherwise runs an infinite loop when
`uv_setup_argv()` has not been called (yet). This is a problem
e.g. in assertions from static constructors, which run before
`main()` and thus before `argc` and `argv` become available.

To solve that, do not allocate more than 1MB of storage for the
title and bail out if we reach that point.
  • Loading branch information
@addaleax
addaleax committed Oct 4, 2020
commit 8ec4407417508bf9a31295a6a80a9ca9d46bab5b
2 changes: 1 addition & 1 deletion src/util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ std::string GetProcessTitle(const char* default_title) {
if (rc == 0)
break;

if (rc != UV_ENOBUFS)
if (rc != UV_ENOBUFS || buf.size() >= 1024 * 1024)
return default_title;

buf.resize(2 * buf.size());
Expand Down