Skip to content

esm: use "node:" internal namespace for builtins #35387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 5 commits into from
Closed

esm: use "node:" internal namespace for builtins #35387

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f12b025
esm: use "node:" namespace for builtins
guybedford Sep 28, 2020
e85f1f4
fixup unknown builtin test and error
guybedford Sep 28, 2020
96cee98
Apply suggestions from code review
guybedford Sep 29, 2020
226320e
include startswith definition
guybedford Sep 29, 2020
3d48169
also include StringPrototypeSlice
guybedford Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
include startswith definition
  • Loading branch information
@guybedford
guybedford authored Sep 29, 2020
commit 226320ec096190c8c2aa8e43da0671753e3259a5
1 change: 1 addition & 0 deletions lib/internal/modules/esm/translators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const {
PromiseReject,
SafeMap,
StringPrototypeReplace,
StringPrototypeStartsWith,
} = primordials;

let _TYPES = null;
Expand Down