Skip to content

module: fix crash on multiline named cjs imports #35275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ctavan wants to merge 3 commits into from
Closed

module: fix crash on multiline named cjs imports #35275

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6298277
module: fix crash on multiline named cjs imports
ctavan Sep 18, 2020
e0febda
Update test/fixtures/es-modules/package-cjs-named-error/fail.cjs
ctavan Sep 20, 2020
af3b991
Update test/fixtures/es-modules/package-cjs-named-error/multi-line.mjs
ctavan Sep 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test/fixtures/es-modules/package-cjs-named-error/multi-line.mjs 
Co-authored-by: Myles Borins <mylesborins@github.com>
  • Loading branch information
@ctavan @MylesBorins
ctavan and MylesBorins committed Sep 20, 2020
commit af3b991cf767476c86e2b3e89ec5377903519939
2 changes: 1 addition & 1 deletion test/fixtures/es-modules/package-cjs-named-error/multi-line.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {
comeOn,
rightNow,
everybody,
} from './fail.cjs';