Skip to content

lib: fix cluster handle leak #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
+57 −1
Closed

lib: fix cluster handle leak #3510

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d5b5fc
lib: fix cluster handle leak
Trott Oct 24, 2015
9c0b131
fixup: swallow ECONNRESET
Trott Oct 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: swallow ECONNRESET
  • Loading branch information
@Trott
Trott committed Oct 26, 2015
commit 9c0b13117f4f51965692d1b48521566bb0f4a0dd
10 changes: 5 additions & 5 deletions test/parallel/test-cluster-shared-leak.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ if (cluster.isMaster) {
worker1.send('die');
worker2.send('die');
}));
// c.on('error', function(e) {
// // ECONNRESET is OK
// if (e.code !== 'ECONNRESET')
// throw e;
// });
conn.on('error', function(e) {
// ECONNRESET is OK
if (e.code !== 'ECONNRESET')
throw e;
});
}));

cluster.on('exit', function(worker, exitCode, signalCode) {
Expand Down