Skip to content

test: add common.mustSucceed #35086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 9 commits into from
Closed

test: add common.mustSucceed #35086

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ce9389a
test: add common.mustSucceed
tniessen Sep 6, 2020
9c54c6b
test: convert to mustSucceed
tniessen Sep 6, 2020
97b15e9
test: convert to mustSucceed
tniessen Sep 6, 2020
4e7fbd8
test: convert to mustSucceed
tniessen Sep 6, 2020
ea01060
test: convert to mustSucceed
tniessen Sep 6, 2020
4b8676e
test: apply manual formatting to previous commits
tniessen Sep 7, 2020
476d930
test: use mustSucceed instead of mustCall
tniessen Sep 7, 2020
c275bf0
doc,test: document common.mustSucceed
tniessen Sep 7, 2020
e43195b
tools,test: add linter rule for mustSucceed
tniessen Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add common.mustSucceed
  • Loading branch information
@tniessen
tniessen committed Oct 13, 2020
commit ce9389a097552ae7144b2ea82d2057a70e1cf900
9 changes: 9 additions & 0 deletions test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,14 @@ function mustCall(fn, exact) {
return _mustCallInner(fn, exact, 'exact');
}

function mustSucceed(fn, exact) {
return mustCall(function(err, ...args) {
assert.ifError(err);
if (typeof fn === 'function')
return fn.apply(this, args);
}, exact);
}

function mustCallAtLeast(fn, minimum) {
return _mustCallInner(fn, minimum, 'minimum');
}
Expand Down Expand Up @@ -714,6 +722,7 @@ const common = {
mustCall,
mustCallAtLeast,
mustNotCall,
mustSucceed,
nodeProcessAborted,
PIPE,
platformTimeout,
Expand Down