Skip to content

src: usage of modernize-use-equals-default #34807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yashLadha wants to merge 1 commit into from
Closed

src: usage of modernize-use-equals-default #34807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: usage of modernize-use-equals-default 
Update the destructor and constructor calls to use the default member
function. This will bascially enables the compiler to do better
optimization as the functions as explicitly defined as trivial.

Explanation can be obtained at: https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html
  • Loading branch information
@yashLadha
yashLadha committed Aug 17, 2020
commit f7f1c7194df8552a7b60aad345c6aaf9ade96a14
4 changes: 2 additions & 2 deletions src/node_file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,9 @@ void FSContinuationData::MemoryInfo(MemoryTracker* tracker) const {
tracker->TrackField("paths", paths_);
}

FileHandleReadWrap::~FileHandleReadWrap() {}
FileHandleReadWrap::~FileHandleReadWrap() = default;

FSReqBase::~FSReqBase() {}
FSReqBase::~FSReqBase() = default;

void FSReqBase::MemoryInfo(MemoryTracker* tracker) const {
tracker->TrackField("continuation_data", continuation_data_);
Expand Down