Skip to content

quic: refactor QuicSession stats and use net.BlockList #34741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 6 commits into from
Closed

quic: refactor QuicSession stats and use net.BlockList #34741

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b92fa36
quic: fixup session ticket app data todo comments
jasnell Aug 7, 2020
717c656
quic: resolve InitializeSecureContext TODO comment
jasnell Aug 7, 2020
ff2159a
quic: clarify TODO statements
jasnell Aug 10, 2020
d3feff4
quic: consolidate stats collecting in QuicSession
jasnell Aug 10, 2020
cc5c456
src: allow instances of net.BlockList to be created internally
jasnell Aug 11, 2020
40e2ca3
quic: use net.BlockList for limiting access to a QuicSocket
jasnell Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
quic: fixup session ticket app data todo comments
  • Loading branch information
@jasnell
jasnell committed Aug 17, 2020
commit b92fa36673d08dff0ea43dfbfc1ec183b4520421
19 changes: 8 additions & 11 deletions src/quic/node_quic_session.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,20 +616,17 @@ class QuicApplication : public MemoryRetainer,

virtual void ResumeStream(int64_t stream_id) {}

virtual void SetSessionTicketAppData(const SessionTicketAppData& app_data) {
// TODO(@jasnell): Different QUIC applications may wish to set some
// application data in the session ticket (e.g. http/3 would set
// server settings in the application data). For now, doing nothing
// as I'm just adding the basic mechanism.
}

// Different QUIC applications may set some application data in
// the session ticket (e.g. http/3 would set server settings in the
// application data). By default, there's nothing to set.
virtual void SetSessionTicketAppData(const SessionTicketAppData& app_data) {}

// Different QUIC applications may set some application data in
// the session ticket (e.g. http/3 would set server settings in the
// application data). By default, there's nothing to get.
virtual SessionTicketAppData::Status GetSessionTicketAppData(
const SessionTicketAppData& app_data,
SessionTicketAppData::Flag flag) {
// TODO(@jasnell): Different QUIC application may wish to set some
// application data in the session ticket (e.g. http/3 would set
// server settings in the application data). For now, doing nothing
// as I'm just adding the basic mechanism.
return flag == SessionTicketAppData::Flag::STATUS_RENEW ?
SessionTicketAppData::Status::TICKET_USE_RENEW :
SessionTicketAppData::Status::TICKET_USE;
Expand Down