Skip to content

test: move test-worker-init-failure to sequential #34740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

test: move test-worker-init-failure to sequential #34740

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cf4c45
test: remove error message checking in test-worker-init-failure
Trott Aug 11, 2020
346d4fe
test: move test-worker-init-failure to sequential
Trott Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: move test-worker-init-failure to sequential 
Unfortunately, the test is sensitive to resource constraints and is
unreliable on macOS in CI when in parallel.

Fixes: #34727
  • Loading branch information
@Trott
Trott committed Aug 11, 2020
commit 346d4fe3fdc6596f2b824f8168086b295fcfdb55
2 changes: 1 addition & 1 deletion test/parallel/test-worker-init-failure.js → test/sequential/test-worker-init-failure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ if (process.argv[2] === 'child') {
// (i.e. single cpu) `ulimit` may not lead to such an error.

worker.on('error', (e) => {
assert.ok(e.code === 'ERR_WORKER_INIT_FAILED' || e.code === 'EMFILE');
assert.ok(e.code === 'ERR_WORKER_INIT_FAILED' || e.code === 'EMFILE' || e.code === 'ENOENT');
});
}

Expand Down