Skip to content

deps: V8: cherry-pick e06ace6b5cdb #34673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

deps: V8: cherry-pick e06ace6b5cdb #34673

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b0a451
deps: V8: cherry-pick e06ace6b5cdb
addaleax Aug 7, 2020
bd0ccf2
test: add vm crash regression test
addaleax Aug 7, 2020
37e4ec2
fixup! test: add vm crash regression test
addaleax Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add vm crash regression test 
Fixes: #34606
  • Loading branch information
@addaleax
addaleax committed Aug 7, 2020
commit bd0ccf2652a08a6ccdc7f7faf45cc677605b4657
15 changes: 15 additions & 0 deletions test/parallel/test-vm-set-property-proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const vm = require('vm');

// Regression test for https://github.com/nodejs/node/issues/34606

const handler = {
getOwnPropertyDescriptor: common.mustCallAtLeast(() => {
return {};
})
};

const proxy = new Proxy({}, handler);
assert.throws(() => vm.runInNewContext('p = 6', proxy));