Skip to content

quic: fixup setSocket support #34669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
Closed

quic: fixup setSocket support #34669

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82ed02a
quic: fixup set_socket, fix skipped test
jasnell Aug 7, 2020
ba73567
quic: check setSocket natRebinding argument, extend test
jasnell Aug 7, 2020
f2e6a0e
quic: add natRebinding argument to docs
jasnell Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
quic: check setSocket natRebinding argument, extend test
  • Loading branch information
@jasnell
jasnell committed Aug 17, 2020
commit ba73567a152708f9049dffd0f801c08b1bb00838
2 changes: 2 additions & 0 deletions lib/internal/quic/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2445,6 +2445,8 @@ class QuicClientSession extends QuicSession {
throw new ERR_INVALID_STATE('QuicSocket is already destroyed');
if (socket.closing)
throw new ERR_INVALID_STATE('QuicSocket is closing');
if (typeof natRebinding !== 'boolean')
throw new ERR_INVALID_ARG_TYPE('natRebinding', 'boolean', true);

await socket[kMaybeBind]();

Expand Down
11 changes: 11 additions & 0 deletions test/parallel/test-quic-simple-client-migrate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,17 @@ const server = createQuicSocket({ server: options });
const s1 = req.socket;
const a1 = req.socket.endpoints[0].address;

await Promise.all([1, {}, 'test', false, null, undefined].map((i) => {
return assert.rejects(req.setSocket(i), {
code: 'ERR_INVALID_ARG_TYPE'
});
}));
await Promise.all([1, {}, 'test', null].map((i) => {
return assert.rejects(req.setSocket(req.socket, i), {
code: 'ERR_INVALID_ARG_TYPE'
});
}));

await req.setSocket(client2);

// Verify that it is using a different network endpoint
Expand Down