Skip to content

module: handle Top-Level Await non-fulfills better #34640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

module: handle Top-Level Await non-fulfills better #34640

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6dd288e
module: handle Top-Level Await non-fulfills better
addaleax Aug 6, 2020
5201960
fixup! module: handle Top-Level Await non-fulfills better
addaleax Aug 6, 2020
9b3aa51
fixup! fixup! module: handle Top-Level Await non-fulfills better
addaleax Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! module: handle Top-Level Await non-fulfills better
  • Loading branch information
@addaleax
addaleax committed Aug 6, 2020
commit 9b3aa518d030736c9b7528f24e8ce8cf86512647
13 changes: 3 additions & 10 deletions lib/internal/modules/run_main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,21 +49,14 @@ function runMainESM(mainPath) {

function handleMainPromise(promise) {
// Handle a Promise from running code that potentially does Top-Level Await.
// In that case, it makes sense to:
// - Treat a rejection as an unhandled exception
// - Set the exit code to a specific non-zero value if the main code never
// finishes running.
// In that case, it makes sense to set the exit code to a specific non-zero
// value if the main code never finishes running.
function handler() {
if (process.exitCode === undefined)
process.exitCode = 13;
}
process.on('exit', handler);
promise
.finally(() => process.off('exit', handler))
.catch((err) => {
internalBinding('errors').triggerUncaughtException(
err, true /* fromPromise */);
});
return promise.finally(() => process.off('exit', handler));
}

// For backwards compatibility, we have to run a bunch of
Expand Down