Skip to content

crypto: add randomInt function #34600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
olalonde wants to merge 11 commits into from
Closed

crypto: add randomInt function #34600

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c7e3d0b
crypto: add randomInt function
olalonde Aug 2, 2020
c068dc4
crypto(randomInt): make max arg inclusive
olalonde Aug 6, 2020
c83e6a9
Update lib/internal/crypto/random.js
olalonde Aug 6, 2020
e746f6c
Update lib/internal/crypto/random.js
olalonde Aug 6, 2020
f8e9397
Update doc/api/crypto.md
olalonde Aug 6, 2020
d6df4b9
lint(crypto): fix js lint for randomInt
olalonde Aug 6, 2020
2cb022f
Update doc/api/crypto.md
olalonde Aug 7, 2020
ca5d07b
crypto(randomInt): make both min and max params required
olalonde Aug 27, 2020
b7a1838
crypto(randomInt): max exclusive, remove min arg
olalonde Aug 31, 2020
b220b3c
crypto(randomInt): put back optional min argument
olalonde Aug 31, 2020
e62fe80
docs: use reference style link in markdown
olalonde Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs: use reference style link in markdown
  • Loading branch information
@olalonde
olalonde committed Sep 2, 2020
commit e62fe80d849100e98c0b716815659cfed456181c
4 changes: 2 additions & 2 deletions doc/api/crypto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2810,8 +2810,7 @@ added: REPLACEME
* `callback` {Function} `function(err, n) {}`.

Return a random integer `n` such that `min <= n < max`. This
implementation avoids [modulo
bias](https://en.wikipedia.org/wiki/Fisher%E2%80%93Yates_shuffle#Modulo_bias).
implementation avoids [modulo bias][].

The range (`max - min`) must be less than `2^48`. `min` and `max` must
be safe integers.
Expand Down Expand Up @@ -3586,6 +3585,7 @@ See the [list of SSL OP Flags][] for details.
[NIST SP 800-131A]: https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-131Ar1.pdf
[NIST SP 800-132]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-132.pdf
[NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
[modulo bias]: https://en.wikipedia.org/wiki/Fisher%E2%80%93Yates_shuffle#Modulo_bias
[Nonce-Disrespecting Adversaries]: https://github.com/nonce-disrespect/nonce-disrespect
[OpenSSL's SPKAC implementation]: https://www.openssl.org/docs/man1.1.0/apps/openssl-spkac.html
[RFC 1421]: https://www.rfc-editor.org/rfc/rfc1421.txt
Expand Down