Skip to content

tools: fix C++ import checker argument expansion #34582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

tools: fix C++ import checker argument expansion #34582

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddc7467
src: fix linter failures
addaleax Jul 31, 2020
22c467d
tools: fix C++ import checker argument expansion
addaleax Jul 31, 2020
de6c455
fixup! tools: fix C++ import checker argument expansion
addaleax Aug 3, 2020
57be4cd
fixup! src: fix linter failures
addaleax Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! tools: fix C++ import checker argument expansion 
Co-authored-by: Richard Lau <riclau@uk.ibm.com>
  • Loading branch information
@addaleax @richardlau
addaleax and richardlau authored Aug 3, 2020
commit de6c455af758c102a163f6360673128a3f6158b0
2 changes: 1 addition & 1 deletion tools/checkimports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ def is_valid(file_name):
files = itertools.chain(files, glob.iglob(pattern))
else:
files = glob.iglob('src/*.cc')
sys.exit(0 if all(map(is_valid, files)) else 1)
sys.exit(0 if all(list(map(is_valid, files))) else 1)