Skip to content

n-api,src: provide asynchronous cleanup hooks #34572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 5 commits into from
Closed

n-api,src: provide asynchronous cleanup hooks #34572

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
65e599f
n-api,src: provide asynchronous cleanup hooks
addaleax Jul 31, 2020
ed40be1
fixup! n-api,src: provide asynchronous cleanup hooks
addaleax Jul 31, 2020
4c90bca
fixup! n-api,src: provide asynchronous cleanup hooks
addaleax Aug 1, 2020
e658a9f
fixup! n-api,src: provide asynchronous cleanup hooks
addaleax Aug 3, 2020
00ab6d8
fixup! fixup! n-api,src: provide asynchronous cleanup hooks
addaleax Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! n-api,src: provide asynchronous cleanup hooks
  • Loading branch information
@addaleax
addaleax committed Aug 3, 2020
commit 00ab6d84be6b421a52b7af73f9d7ab4c7d20627d
2 changes: 1 addition & 1 deletion src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,7 +871,7 @@ NODE_EXTERN void RemoveEnvironmentCleanupHook(v8::Isolate* isolate,
* `cb(cbarg)` *must* be called, and attempting to remove the cleanup hook will
* have no effect. */
struct ACHHandle;
struct DeleteACHHandle { void operator()(ACHHandle*) const; };
struct NODE_EXTERN DeleteACHHandle { void operator()(ACHHandle*) const; };
typedef std::unique_ptr<ACHHandle, DeleteACHHandle> AsyncCleanupHookHandle;

NODE_EXTERN AsyncCleanupHookHandle AddEnvironmentCleanupHook(
Expand Down