Skip to content

http: provide keep-alive timeout response header #34561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 3 commits into from
Closed

http: provide keep-alive timeout response header #34561

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9719ec1
http: provide keep-alive timeout response header
ronag Jul 30, 2020
003e581
fixup
ronag Jul 30, 2020
b4e8b79
fixup
ronag Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@ronag
ronag committed Jul 30, 2020
commit 003e581088b6da260b11b37c8a9b2f80ac7cd90e
2 changes: 1 addition & 1 deletion lib/_http_outgoing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ function _storeHeader(firstLine, headers) {
if (shouldSendKeepAlive) {
header += 'Connection: keep-alive\r\n';
if (this._keepAliveTimeout) {
const timeoutSeconds = MathFloor(this._keepAliveTimeout - 500) / 1000;
const timeoutSeconds = MathFloor(this._keepAliveTimeout) / 1000;
Copy link
Copy Markdown
Member Author

@ronag ronag Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we always set this to less than the actual timeout? And if so what is a good algorithm?

Copy link
Copy Markdown
Member Author

@ronag ronag Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based nodejs/undici#279 I feel that any client should always assume a value less than the hint. So further reducing it here can be counter productive.

header += `Keep-Alive: timeout=${timeoutSeconds}\r\n`;
Copy link
Copy Markdown
Contributor

@killagu killagu Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not add the header if the Keep-Alive exits maybe better.

Copy link
Copy Markdown
Member Author

@ronag ronag Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR welcome

Copy link
Copy Markdown
Contributor

@atian25 atian25 Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#35096

}
} else {
Expand Down