test: replace flaky pummel regression tests

These tests were written a long time ago, and use the allocation of large amounts of unused memory as a way to detect use-after-free problems with Buffers. As a result, the tests are resource-intensive and may crash because of that. Replace them with a more modern test. We don’t explicitly try to *detect* use-after-free conditions, and instead rely on e.g. ASAN (or the process just crashing hard) to do that for us. Fixes: #34527
nodejs · addaleax · Jul 27, 2020 · Jul 31, 2020 · Jul 30, 2020 · 475796a6a13e6e2af4e28e493e673af4be01a7ba
commit 475796a6a13e6e2af4e28e493e673af4be01a7ba
diff --git a/test/parallel/test-fs-write-reuse-callback.js b/test/parallel/test-fs-write-reuse-callback.js
@@ -0,0 +1,38 @@
+// Flags: --expose-gc
+'use strict';
+const common = require('../common');
+const tmpdir = require('../common/tmpdir');
+const assert = require('assert');
+const path = require('path');
+
+// Regression test for https://github.com/nodejs/node-v0.x-archive/issues/814:
+// Make sure that Buffers passed to fs.write() are not garbage-collected
+// even when the callback is being reused.
+
+const fs = require('fs');
+
+tmpdir.refresh();
+const filename = path.join(tmpdir.path, 'test.txt');
+const fd = fs.openSync(filename, 'w');
+
+const size = 16 * 1024;
+const writes = 1000;
+let done = 0;
+
+const ondone = common.mustCall((err) => {
+  assert.ifError(err);
+  if (++done < writes) {
+    if (done % 25 === 0) global.gc();
+    setImmediate(write);
+  } else {
+    assert.strictEqual(
+      fs.readFileSync(filename, 'utf8'),
+      'x'.repeat(writes * size));
+  }
+}, writes);
+
+write();
+function write() {
+  const buf = Buffer.alloc(size, 'x');
+  fs.write(fd, buf, 0, buf.size, -1, ondone);
+}
diff --git a/test/pummel/test-regress-GH-814.js b/test/pummel/test-regress-GH-814.js
diff --git a/test/pummel/test-regress-GH-814_2.js b/test/pummel/test-regress-GH-814_2.js