Skip to content

http: don't write error to socket #34465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 5 commits into from
Closed

http: don't write error to socket #34465

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6657553
http: don't write error to socket
ronag Jul 21, 2020
40f7def
fixup: linting
ronag Jul 21, 2020
56a12f3
fixup: altenrative
ronag Jul 21, 2020
9b70294
fixup: add test
ronag Jul 21, 2020
08a3fa9
fixup: update docs
ronag Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ function socketOnError(e) {
this.on('error', noop);

if (!this.server.emit('clientError', e, this)) {
if (this.writable) {
if (this.writable && this.bytesWritten === 0) {
const response = e.code === 'HPE_HEADER_OVERFLOW' ?
requestHeaderFieldsTooLargeResponse : badRequestResponse;
this.write(response);
Expand Down