Skip to content

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot #34454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 1 commit into from
+10 −0
Closed

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot #34454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot 
Otherwise the build would fail with
`./configure --experimental-quic --ninja` as the list of per-Environment
values would not match and the code cache builder would not generate
code cache for the quic JS sources. This is more or less a band-aid -
a proper fix would be to aggregate these flags into something
that can be included by all these different binary targets.
See #31074.
  • Loading branch information
@joyeecheung
joyeecheung committed Jul 22, 2020
commit e4d50ab2832666c68348984e60f6818c8fae27b6
10 changes: 10 additions & 0 deletions node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1376,6 +1376,11 @@
'HAVE_OPENSSL=1',
],
}],
[ 'node_use_openssl=="true" and experimental_quic==1', {
'defines': [
'NODE_EXPERIMENTAL_QUIC=1',
],
}],
['v8_enable_inspector==1', {
'defines': [
'HAVE_INSPECTOR=1',
Expand Down Expand Up @@ -1430,6 +1435,11 @@
'HAVE_OPENSSL=1',
],
}],
[ 'node_use_openssl=="true" and experimental_quic==1', {
'defines': [
'NODE_EXPERIMENTAL_QUIC=1',
],
}],
['v8_enable_inspector==1', {
'defines': [
'HAVE_INSPECTOR=1',
Expand Down