Skip to content

n-api: run all finalizers via SetImmediate() #34386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabrielschulhof wants to merge 2 commits into from
Closed

n-api: run all finalizers via SetImmediate() #34386

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f04eaa7
n-api: run all finalizers via SetImmediate()
Jul 15, 2020
540ec7e
fixup! testFinalizerException to gc until it throws
Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! testFinalizerException to gc until it throws
  • Loading branch information
Gabriel Schulhof committed Jul 23, 2020
commit 540ec7ee561c77340a205a8b5f9a59f72f81452a
18 changes: 14 additions & 4 deletions test/js-native-api/test_exception/testFinalizerException.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,24 @@ if (process.argv[2] === 'child') {
} catch (anException) {
anException.binding.createExternal();
}
const interval = setInterval(() => {
clearInterval(interval);
}, 100);

// Collect garbage 10 times. At least one of those should throw the exception
// and cause the whole process to bail with it, its text printed to stderr and
// asserted by the parent process to match expectations.
let gcCount = 10;
(function gcLoop() {
global.gc();
if (--gcCount > 0) {
setImmediate(() => gcLoop());
}
})();
return;
}

const assert = require('assert');
const { spawnSync } = require('child_process');
const child = spawnSync(process.execPath, [ __filename, 'child' ]);
const child = spawnSync(process.execPath, [
'--expose-gc', __filename, 'child'
]);
assert.strictEqual(child.signal, null);
assert.match(child.stderr.toString(), /Error during Finalize/m);